adhocore / php-cli

PHP Console Application made easy- build great console apps with ease. Comes with Zero Dependency and Autocompletion support. Think of it as a PHP cli application framework.

https://github.com/adhocore/php-cli

MIT License

334 stars 35 forks source link

In the Composer script, the tools used are external, and I want to make it easier for them to reside in dependencies #62

Closed dongasai closed 3 years ago

dongasai commented 3 years ago

I think I could start a PR

adhocore commented 3 years ago

the tools used are external, and I want to make it easier for them to reside in dependencies

sorry what is external here?

dongasai commented 3 years ago

Examples are 'test:cov' needed 'pcov', and 'cs:sniff' needed 'phpcs'

adhocore commented 3 years ago

pcov is pecl installable extension for code coverage, while phpcs might be composer dep (i think first need to check #57 and #59)

dongasai commented 3 years ago

59 The "tools/ PHPCS "executable and the "phpunit" executable do not exist

pattisahusiwa commented 3 years ago

phpcs and phpcbf are installed using https://github.com/phar-io/phive, please check the github page. phpunit should be installed by composer.

dongasai commented 3 years ago

So what I mean is that this can be used for dependency management in composer.json instead of a separate installation

pattisahusiwa commented 3 years ago

Composer should be used to manage project dependencies only, not the external tools. That's why Bergmann doesn't recommend installing phpunit using composer.