adhocore / php-cron-expr

Ultra lightweight, Dependency free and Super Fast Cron Expression parser for PHP

https://github.com/adhocore/php-cron-expr

MIT License

50 stars 5 forks source link

Remove back-slash before native functions #10

Closed peter279k closed 5 years ago

peter279k commented 5 years ago

Changed log

Remove the back-slash before the native PHP functions because the native PHP functions have already been loaded before loading the class with specific namespace in PHP run time. And the native PHP functions will not effect the namespace. The more details are available here.
The Travis CI build is broken in this PR, but it's passed in my branch of forked repository.

adhocore commented 5 years ago

Much thanks for concern and time taking :) They are actually purposely done so for not having conflict (maynot happen) and for really micro optimization as said in https://veewee.github.io/blog/optimizing-php-performance-by-fq-function-calls/

peter279k commented 5 years ago

@adhocore, thank you for your reply. In this blog post, the foo function is the user-defined function and that functions are native PHP functions. This is the post http://php.net/manual/en/language.namespaces.fallback.php in official doc to explain the native functions.

adhocore commented 5 years ago

actually the fqfn is for any functions either userland or native

peter279k commented 5 years ago

@adhocore, I've known that. I noticed that you use the \ for every native PHP functions. I will close this PR and it's consistency for your code in other repos.