search

adhocteam / nytimes-library

A collaborative documentation site, powered by Google Docs.
https://nyt-library-demo.herokuapp.com/
Apache License 2.0
1 stars 1 forks source link

Content Library: Upgrade Node version #41

Closed gunsch closed 2 years ago

gunsch commented 2 years ago

NPM no longer works with Node 10, but this application is currently node10 based.

Do a Node upgrade, ideally jumping up to Node 16 (current LTS) and make sure the app still works.

This also needs to show up in app.yaml, changing the GAE runtime to nodejs16 (https://cloud.google.com/appengine/docs/standard/nodejs/runtime)

zenkimoto commented 2 years ago

I don't know if makes any difference but I've been developing with node.js v16.13.2 since the start and I haven't ran into any issues.

I've updated the app.yaml and Dockerfile files to node 16. I don't know if there's any Terraform changes required. The branch is ay/node-upgrade if @ahinh43 needs to make changes.

zenkimoto commented 2 years ago

Just FYI, nodejs 16 EOL date just moved up to 9/11/23.

https://nodejs.org/en/blog/announcements/nodejs16-eol/

ahinh43 commented 2 years ago

No terraform code changes are needed, this is the only area I had in mind for the version upgrade. We'll want to sync that up to node 16 so our development builds and CI builds are the same

After that then it all LGTM