search

adhocteam / pushup

Pushup is for making modern, page-oriented web apps in Go
https://pushup.adhoc.dev
MIT License
839 stars 30 forks source link

Embed does not seem to actually embed #122

Open RightFootConsulting opened 6 months ago

RightFootConsulting commented 6 months ago

I am testing out the project with a build built on the windows command line. I have moved the binary copy of my forked version which fixes another issue with the sysprocattr not working in windows, and that is out for review and may need to be modified further since there is also darwin to consider.

func sysProcAttr(cmd *exec.Cmd) {
cmd.SysProcAttr = &syscall.SysProcAttr{
    CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP,
}

}

Any whoo, I notice when you call a binary pushup.exe file that the scaffold files are not being handled correctly in the binary, it's like they are not there:

PS C:\stuff> .\pushup\pushup.exe new my_project

    //
 //  //      //////                        //
            //    //  //    //    //////  //////    //    //  //////
           //////    //    //  ////      //    //  //    //  //    //
          //        //    //      ////  //    //  //    //  //    //
         //          //////  //////    //    //    //////  //////
                                                          //
                                                         //

new command: copying scaffold file to project dir opening file from FS scaffold\layouts\default.up: open scaffold\layouts\default.up: file does not exist

Looking in to cause but I figured I should raise this as an issue.

RightFootConsulting commented 6 months ago

This pull request fixes the issue.

https://github.com/adhocteam/pushup/pull/121