adhocteam / soapbox

Apache License 2.0
11 stars 3 forks source link

Defer clean-up of blue instances in case of failure #173

Closed robertfairhead closed 6 years ago

robertfairhead commented 6 years ago

With reorg I did in https://github.com/adhocteam/soapbox/pull/171 we had to pull out the old defer in the middle of deploying in order to clean-up the blue instances. We'll need to add back in handling of "failed" deploys that need clean-ups.

We withheld that change since that diff is large enough as is. Once that lands, I can open a PR for @kalilsn to review with that additional fix.