Refactored core code to make it modular and readable

adi1090x / battery-wallpaper

Simple bash script to set wallpaper according to battery percentage with charging animations.

GNU General Public License v3.0

391 stars 22 forks source link

Refactored core code to make it modular and readable #2

Closed shubhamoli closed 4 years ago

shubhamoli commented 4 years ago

File: battery_wall.sh

Changes:

Made code more modular using functions
Migrated if-elif equality based logic to division based
removed exec call, instead called main function infintely

Important:

Code is not tested as I don't have a machine right now (only cloud native VMs)

adi1090x commented 4 years ago

good, but it doesn't work.

shubhamoli commented 4 years ago

Since, PR #3 is merged now i can test my code it in my mac:

Thanks @sfroment for the PR

Meanwhile, I've to refactor my code and resolve conflicts

sfroment commented 4 years ago

@shubhamoli btw do not forget to run the brew install wallpaper

adi1090x commented 4 years ago

i would love to use your code, if you can... add MacOS support too. at least i don't have to exec the script, also improve the main function. @sfroment did a good job. hope you'll too.

adi1090x commented 4 years ago

Since, PR #3 is merged now i can test my code it in my mac:

Thanks @sfroment for the PR

Meanwhile, I've to refactor my code and resolve conflicts

I've updated the code, merged your's too.