search

adi1090x / dynamic-wallpaper

A simple bash script to set wallpapers according to current time, using cron job scheduler.
GNU General Public License v3.0
1.91k stars 114 forks source link

Code repetition #30

Closed eepykate closed 3 years ago

eepykate commented 4 years ago

Near line 59, there is a case statement that checks if the OSTYPE is 'linux', but in the end, that statement is useless since you're using the same code for every other OS type.

Suggested change: the case statement is removed and replaced with lines 61-75

PPHyperion commented 4 years ago

@GaugeK you can clone this project edit your suggested changes and open a pull request.

eepykate commented 4 years ago

@PPHyperion Good idea.