adi1090x / dynamic-wallpaper

A simple bash script to set wallpapers according to current time, using cron job scheduler.
GNU General Public License v3.0
1.91k stars 116 forks source link

Improve image path resolution #86

Closed displeased closed 2 years ago

displeased commented 2 years ago

This is my first Pull Request - feel free to reject the commit that changes the dwall help message, that might have been an over-stretch.

Most of the work of this pull request was spent using the shellchecktool to bring the main dwall script and associated helper scripts into compliance with shellcheck warnings and errors.

However, the most relevant change is probably the change to path resolution for the image directory (stored in the DIR variable). I changed the path resolution for images to be relative to the current directory of the script; This allows the script to resolve the correct directory for images regardless of location. This also allowed me to remove the testing script (test.sh), reducing redundant files in the process.