search

adi1090x / polybar-themes

A huge collection of polybar themes with different styles, colors and variants.
GNU General Public License v3.0
5.59k stars 406 forks source link

Rofi menus appearnce in my system do not match screenshots #143

Open danielfm opened 2 years ago

danielfm commented 2 years ago

Not sure what might cause this, but apparently Rofi menu items doesn't seem to render properly.

2021-09-01_16-52

This is the only issue I have, everything else looks awesome just like the screenshots :)

Anyone have ideas of what might be causing this, or any suggestions on things I can try?

I have no Rofi configuration files in .config/rofidirectory, and I'm using Rofi 1.7.0

danielfm commented 2 years ago

I think I found what is the issue.

If I paste the following code in the element-icon and element-text sections of the corresponding .rasi style file, it seems to work correctly:

    background-color:  @al;
    text-color: inherit;

2021-09-01_20-11

pandjipras commented 2 years ago

i have same issue with start launcher. but i dont have idea how to fix it.

pandjipras commented 2 years ago

i have same issue with start launcher. but i dont have idea how to fix it.

i fix it with @danielfm suggested in launcher.rasi Screenshot _1

danielfm commented 2 years ago

I have a fork in which I fixed this for all themes:

https://github.com/danielfm/polybar-themes

(This fork is for my personal use only, so I don't plan on maintaining it and keeping it in sync with the upstream repo. If the owner accepts a pull request, I can submit it)

Effiti commented 2 years ago

you can patch an existing install by running the following on all .rasi files, replacing file.rasi with the filename

cat file.rasi | sed "s/element-icon\s*{$/element-icon {\n    background-color:  @al;\n    text-color: inherit;\n/g" | sed "s/element-text\s*{$/element-text {\n    background-color:  @al;\n    text-color: inherit;\n/g" | tee file.rasi
jallphin commented 2 years ago

This is indeed a valid issue. Wondering if we can get a PR from @danielfm fix. For the record I'm using i3-gaps, pretty basic install. To fix the entire install I just did:

find ~/ -name '*.rasi' | xargs sed -i "s/element-text\s*{$/element-text {\n    background-color:  @al;\n    text-color: inherit;\n/g"

and

find ~/ -name '*.rasi' | xargs sed -i "s/element-icon\s*{$/element-icon {\n    background-color:  @al;\n    text-color: inherit;\n/g"

To update all the .rasi files at once. Thanks @effiti for his code above.