adi1090x / rofi

A huge collection of Rofi based custom Applets, Launchers & Powermenus.
GNU General Public License v3.0
6.79k stars 316 forks source link

syntax issues,- line 54 in config.rasi #179

Open AnirudhG07 opened 2 months ago

AnirudhG07 commented 2 months ago

Hi i just installed the cool themes you made. Thanks. But when i run rofi -show window or anything, it gives below error 41afc251-92cb-42db-9bf4-92965fd84059

It seems that the error is in line 54 of config.rasi I saw and found the issue.

BEFORE

    /*-vv-------- Fallback Icon ----------*/
    run,drun {
        fallback-icon: "application-x-addon";
    }

AFTER

    /*-vv-------- Fallback Icon ----------*/
    run-drun {
        fallback-icon: "application-x-addon";
    }

With this fix, the rofi works properly.

The , in line 54 is purposely there or a bug? If its a bug, Is it ok if i make a PR and fix it?

vigneshwaran-48 commented 1 week ago

I think it should be handled like this

    run {
        fallback-icon: "application-x-addon";
    }

        drun {
        fallback-icon: "application-x-addon";
    }
snwfdhmp commented 5 days ago

yes, it should be merged

Meqr1 commented 11 hours ago

please merge this...