adi1090x / rofi

A huge collection of Rofi based custom Applets, Launchers & Powermenus.
GNU General Public License v3.0
6.51k stars 303 forks source link

Wrong size of buttons #33

Closed PoSayDone closed 3 years ago

PoSayDone commented 3 years ago

screenshot_20201218_023835

Syphdias commented 3 years ago

I have the same issue and would like to add some details:

❯ rofi -version
Version: 1.6.1
❯ lsb_release -a
LSB Version:    n/a
Distributor ID: ManjaroLinux
Description:    Manjaro Linux
Release:    20.2
Codename:   Nibia

I have these issues since rofi version 1.6 I think which were supposed to be fixed in #28 I think. To install I cloned the master branch of this repo and used the setup.sh with the 1080p option (even though I have 2x 1440p – more on that later) and then ran ~/.config/rofi/bin/powermenu. For debugging purposed I tried the following steps:

None of those worked.

@PoSayDone, is there anything similar in your setup? Anything you tried to fix it?

PoSayDone commented 3 years ago

I also have arch-based system. I have single 1080p monitor.

I've tried:

Syphdias commented 3 years ago
  • To install an older version of rofi

Judging from comments in #28 rofi 1.6 changed quite a lot which makes me think it's unlikely that pre-1.6-rofi will ever work again – and why would it. If you are willing to downgrade rofi (which I am not) you could use the old scripts.

I'm a bit mad that @adi1090x cleared the git history and started anew and didn't keep the old commits on an orphan branch pre-rofi1.6 or something like that.

If you must, @PoSayDone, I still have a (not quite up-to-date) version of the old commits/trees as a fork https://github.com/syphdias/rofi where I once opened #12 from.

PoSayDone commented 3 years ago
  • To install an older version of rofi

Judging from comments in #28 rofi 1.6 changed quite a lot which makes me think it's unlikely that pre-1.6-rofi will ever work again – and why would it. If you are willing to downgrade rofi (which I am not) you could use the old scripts.

I'm a bit mad that @adi1090x cleared the git history and started anew and didn't keep the old commits on an orphan branch pre-rofi1.6 or something like that.

If you must, @PoSayDone, I still have a (not quite up-to-date) version of the old commits/trees as a fork https://github.com/syphdias/rofi where I once opened #12 from.

I am going to try it when I will be at home

czyzniek commented 3 years ago

Any news on that one? 🙂

Syphdias commented 3 years ago

I had some time and tried a few things. The thing that seemed to work is adding bottom padding to element. In my case I tried it for powermenu and for some styles and resolutions.

For card_square on 1440p (with 1080p config) this worked:

--- /tmp/card_square.rasi   2021-01-05 11:32:37.605011671 +0100
+++ ~/.config/rofi/powermenu/card_square.rasi   2021-01-05 11:35:35.067078412 +0100
@@ -81,6 +81,7 @@
     text-color:                     @foreground;
     orientation:                    horizontal;
     border-radius:                  0%;
+    padding: 0 0 2%;
 }

 element-text {

But the 2% are very trial and error and for different styles the value differed. It also differed when I set my screen resolution to 1080p (for some styles).

I am not sure this is the solution. It would need to be adjusted for every style (and resolution) manually by trial and error (at least for me, since I can't find proper dev tools for rofi theming). Also should the value be in px, % or another unit?

Could someone with it working without adjustments try the following:

  1. Open powermenu with card_square. Is it looking okay?
  2. Modify ~/.config/rofi/powermenu/card_square.rasi with the patch from above
  3. Open powermenu with card_square again. Is it still looking okay?
  4. Post their findings here

Some comment from @adi1090x would be nice :)

adi1090x commented 3 years ago

Good work @Syphdias Anyway, Fixed this issue on master branch.

Syphdias commented 3 years ago

Anyway, Fixed this issue on master branch.

I can confirm that the shapes with a screen resolution of 1920x1080 (sadly not my native one).

Quick question: Why does the setup say 1366x768 and the folder says 720p? Is there a reason for that?