search

adi1090x / rofi

A huge collection of Rofi based custom Applets, Launchers & Powermenus.
GNU General Public License v3.0
6.51k stars 303 forks source link

Powermenu cannot log out of openbox #41

Closed ynavott closed 2 years ago

ynavott commented 3 years ago

After not understanding why the logout function of the powermenu did not log out of the system, I looked into powermenu.sh and on line 104, when checking for the $DESKTOP_SESSION envvar for the logout, the script tries to comapre it to "Openbox", which seems correct at first but after checking the envvar as it is defined on my system with echo $DESKTOP_SESSION I saw that the envvar returns openbox with a small o, and not a capital O. After editing the script with the correct small o, the logout function worked.

I am not sure if this is only a problem on my machine but I think comparing for both Openbox and openbox or somehow ignoring capitalization would be preferable.

MoDyPL commented 3 years ago

the same issue with i3

ynavott commented 2 years ago

This was apparently fixed by the developer without mentioning anything here, closing.

ynavott commented 2 years ago

Actually, they did not. Issue still remains.

maxice8 commented 2 years ago

I made #69 that should fix it, can you test it and give an acknowledgement ?