search

adi2412 / cesium

WebGL virtual globe and map engine
cesiumjs.org
Other
1 stars 0 forks source link

Resizable code window makes the globe disappear #3

Closed emackey closed 9 years ago

emackey commented 9 years ago

The "Knockout" branch has a resizable code editor window, but resizing it larger often makes the globe window disappear, and sizing it smaller makes the globe reappear.

emackey commented 9 years ago

Also, when viewing a documentation tab or "white" content in Cesium, there's no discernible border between the left and right windows. There should be more of a visual edge here, even if both windows have white backgrounds, plus some indication that the user is able to grab and drag the edge.

adi2412 commented 9 years ago

Fixed in b6de1effa53ff67b3092e101e28225d5828d9f3f and 7e4a531ca496c2fff7ffbda029f3bf2b58997003

emackey commented 9 years ago

I can still get the globe to disappear, even in Hello World just by dragging the editor to the right. Chrome on Win 7.

adi2412 commented 9 years ago

Are you sure about this? I'm not able to replicate this issue. It shouldn't be happening after the fix, since the min width is specified.

emackey commented 9 years ago

This was still broken for me on the GSoC pencils-down date, but appears to have been subsequently fixed in 850857d23.

adi2412 commented 9 years ago

To be honest, I'm not sure that's even possible. Looking at the commit, the fix for this was in b6de1effa53ff67b3092e101e28225d5828d9f3f. I'm not sure how the recent commit could have fixed this.