search

adi64 / terminus

Game Programming Seminar 2014/15
3 stars 0 forks source link

57 create ui #122

Closed Fidge123 closed 9 years ago

Fidge123 commented 9 years ago

Still shooting to the left for some reason

Fidge123 commented 9 years ago

DO NOT MERGE YET, this is a work in progress

Fidge123 commented 9 years ago

Not completely broken anymore. A new review would be nice :smile:

Remaining issues that need to be solved at some point:

Fidge123 commented 9 years ago

Brace yourself. The UI is coming!

Please review and test my branch. If everything is working as intended on your machine Id be very happy if this would be merged to master.

(Shooting slightly to the left is intended as the bullet needs time to fly while we are moving sideways. Or is the bullet moving sideways and we are going straight.... whatever it is it is intended. Its a feature not a bug!)

lw0 commented 9 years ago

Tests on Linux succeeded. I'm not quite sure about the projectiles drifting sideways, but that is nothing to be fixed here (ref #134). I don't know whether they were intended to, but the UI-wagons do not give any information about the reload time. I thought that is what the white bar should do? Given it is the intended behavior, I am honored to announce my consent to merging this most excellent piece of work.

Fidge123 commented 9 years ago

Thank you. To clarify: the projectiles have to drift sideways slightly as physics demands. It seems off since the camera is not centered on the wagon therefore the shots spawn to the left of the camera additionally to the intended drifting left.

The concern with the reload is correct and I will fix this before merging. I am planning on pushing a new version tonight, we can review and make final decisions on Monday.

Fidge123 commented 9 years ago

when merged close #104 close #107 close #57

adi64 commented 9 years ago

I really dig the UI! :) However, for some reason movig the camera with the mouse is really sluggish for me. I compared with the master and that one was fine. Do you also experience this? Apart from that, I think we're set :+1:

Fidge123 commented 9 years ago

I agree but it only happens sometimes for me. On mobile it seems fine