search

adi90x / rancher-active-proxy

All in one active reverse proxy for Rancher ! For Kubernetes : https://github.com/adi90x/kube-active-proxy
MIT License
156 stars 55 forks source link

Update let's encrypt by adding sleep #23

Closed jakubknejzlik closed 7 years ago

jakubknejzlik commented 7 years ago

This changes are required (in my case) to successfuly generate LE certificates.

adi90x commented 7 years ago

Hello, Don't really understand what it could change to add a 30s sleep to this script

jakubknejzlik commented 7 years ago

Hello @adi90x, in my case the response for acme challenge is 503 (maybe the nginx can't update it's config "in time"). After 30s delay (maybe 10s could be enough) is everything correctly updated and le certificates are successfully generated.

adi90x commented 7 years ago

Thanks for using RAP , no probleme to merge that if it increase stability ! Can you push it to https://gitlab.com/adi90x/rancher-active-proxy.git ? As it is the main repo for RAP , if you can not I will do it tonight !

jakubknejzlik commented 7 years ago

Looks like I can't :)

Only those with write access to this repository can merge pull requests.
adi90x commented 7 years ago

Arf I guess you need to have an account on gitlab.com to send pull request as I have set everything to public normaly ! Don't worry , i will do it tonight

adi90x commented 7 years ago

i just commit it on gitlab ( however seems that I have a problem on the workflow , not related to that => I am looking into it now ! )

adi90x commented 7 years ago

Pull request add on gitlab side , workflow is working and image is rebuilding on docker hub ! Thanks a lot for the PR , do not hesitate to submit any other modification !