adi90x / rancher-active-proxy

All in one active reverse proxy for Rancher ! For Kubernetes : https://github.com/adi90x/kube-active-proxy
MIT License
156 stars 55 forks source link

Renew https certificat #25

Closed ValentinOdier closed 6 years ago

ValentinOdier commented 7 years ago

Hi,

I have been using "rancher-active-proxy" for a while (and it's great!) and i have noticed that my certificat are not renew when out of date. I then end up with an outdated certificate breaking https :/.

I couldn't find a way to force my certificate to be renew. I haven't seen anything on how to handle the renew process and i was wondering if you had any idea how to do so or what i could be forgetting.

Thanks for your help.

ValentinOdier commented 7 years ago

Hi again,

I think i just found what was going on :

You use a cron tab to run /app/letsencrypt.sh, if i'm correct this script is in charge of creating / renew all certificates.

I had a mistake in my cron variable and was only checking once a year, that's why my certificates were not renew.

I also think that if you add a new domain (let's say you add a new container with a new domain) the certificate is not created and the nginx configuration is wrong like in this issue : https://github.com/adi90x/rancher-active-proxy/issues/4

After forcing /app/letsencrypt.sh to run my certificates are there and everything works. It looks like the certificate will never be created unless you run letsencrypt.sh, is this correct ? I think it should be added to the documentation.

ps : This would also explain : https://github.com/adi90x/rancher-active-proxy/issues/20

ValentinOdier commented 6 years ago

Does not happen anymore