search

adi90x / rancher-active-proxy

All in one active reverse proxy for Rancher ! For Kubernetes : https://github.com/adi90x/kube-active-proxy
MIT License
156 stars 55 forks source link

Always render `server` and `upstream` for containers. #42

Closed fabiomontefuscolo closed 6 years ago

fabiomontefuscolo commented 6 years ago

Hello!

We are using RancherActiveProxy for a while. It is an amazing piece for Rancher! Thank very much for this!! :)

Sometimes we got some troubles when upgrading our backend containers. During container upgrade, RAP does not render the 'upstream' and 'server' block and instead throws 404 or 503, RAP does 301 to a different website. The main problem is 301 is very sticky on browsers and users can't back to correct website after upgrade.

We also tried "start before stopping" option, but without luck. So I did this change to always render upstream and server blocks but it throws 502 when backend is unavailable. I know it is not good to user see 502 message, but I think it is better than redirect with 301 to a unexpected place.

What do you think??

Again, thank you for RAP :)

ValentinOdier commented 6 years ago

Hi.

I think you should submit it on gitlab see : https://github.com/adi90x/rancher-active-proxy#contributing

The official repo is on gitlab : https://gitlab.com/adi90x/rancher-active-proxy/

Otherwise i agree with you we have the same issue here :)

fabiomontefuscolo commented 6 years ago

Hello @ValentinOdier

There is a merger request there, at https://gitlab.com/adi90x/rancher-active-proxy/merge_requests/30.

I did a pull request here because I saw the change cange came from github, no from gitlab.

adi90x commented 6 years ago

Very nice PR ! Just merged it ! Thanks a lot for your help really appreciate even if I don't have a lot of time to maintain this repo !