No handshake on scrobble

[GoogleCodeExporter]

In line 3651 of pylast.py, in method report_now_playing, if scrobbler request 
fails, handshake is forced and submissions_url as well as nowplaying_url are 
obtained. 

These values are never requested elsewhere so if one tries scrobbling without 
reporting nowplaying, as in line 3683 in method scrobble, handshake is not 
performed and scrobbles are never submitted. Probably should be as below 
(replacing line 3683), right?

try:
            ScrobblerRequest(self.submissions_url, params, self.network).execute()
        except BadSessionError:
            self._do_handshake()
            self.scrobble( artist, title, time_started, source, mode, duration, album, track_number, mbid);

Original issue reported on code.google.com by the.wa.s...@gmail.com on 20 Oct 2010 at 10:21

[GoogleCodeExporter]

As of r237 this method of scrobbling is obsolete, please use the new API 
composed of Network.scrobble(...), Network.scrobble_many(...), and 
Network.update_now_playing(...) instead. Also reporting the same bug several 
times isn't very helpful, please refrain from doing that.

Original comment by amr.hassan on 5 Jan 2011 at 1:32

• Changed state: WontFix

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Issue 49 has been merged into this issue.

Original comment by amr.hassan on 5 Jan 2011 at 1:36

[GoogleCodeExporter]

Issue 50 has been merged into this issue.

Original comment by amr.hassan on 5 Jan 2011 at 1:37