adibarra / enchant-tweaker

Tweak many enchantment related mechanics while keeping the vanilla minecraft feel.
https://modrinth.com/mod/enchant-tweaker
MIT License
4 stars 0 forks source link

bug: Duplicate of the same enchant when using enchantment table #20

Closed Wide0125 closed 8 months ago

Wide0125 commented 8 months ago

What happened?

There is a not too rare chance to get duplicates of the same enchants when using the enchantment table to enchant items. After testing, found it applied to swords and armor pieces.

What should have happened?

Only one of that enchantment should've been applied

How to reproduce?

Use an enchantment table to enchant armor or swords at level 30 a couple times.

What is the jar file name?

enchanttweaker-1.4.5+mc1.20-1.20.1.jar

What Minecraft version?

Fabric 1.20.2

Any relevant logs?

https://mclo.gs/UOn2Ze8

Anything else?

Screenshot 2023-12-19 at 10 22 43 PM Screenshot 2023-12-19 at 10 22 41 PM Screenshot 2023-12-19 at 10 22 39 PM Screenshot 2023-12-19 at 10 19 38 PM

Before submitting...

adibarra commented 8 months ago

Hello, thanks for the report! I'll start looking into this. Just to clarify were you using any other mods at the same time? I'd appreciate it if you could attach a logfile (and/or mod list) if you have one.

Wide0125 commented 8 months ago

Screenshot 2023-12-22 at 12 24 02 AM I've added our villager discounts, rcsd, and enchanting tweaks (to implement the god armor and god sword functionality with no bug) since I encountered the bug.

JairusSW commented 8 months ago

I also am getting the same issue. image

adibarra commented 8 months ago

I was able to reproduce it as well and have been trying to track it down. I just haven't had the time to nail it down yet. Sorry about the wait on this one.

JairusSW commented 8 months ago

Hey, don't worry. It's all good

adibarra commented 8 months ago

It should be fixed now. The fix will be included in the next update (v1.4.7)

JairusSW commented 8 months ago

Confirmed. Working in latest release. Thank you!