Mod Compatibility?

[Ultimushadow]

What does it do?

Certain mods have enchantments similar to vanilla enchantments, adding compatibility to them would help packs blend easier.

Why add it?

Well, it would make it a lot easier on the user end to tweak the enchantments to make a more cohesive pack. As I understand, the point of this mod is to give players more control over the vanilla enchantments, so this seems like an extension of that idea.

Anything else?

Here are some of the mods/enchantments I think could easily be folded into compat: Soul Fire'd - Adds Soul Flame and Soul Fire Aspect respectively, being able to tweak the levels without going into the mod files (and soul flame functioning similar to flame with your mixin) would fit better with the mod.

AdditionZ adds a couple enchants but Stampede is the one I think would benefit most from your system, being able to hit levels higher than 3 with longer charges/more damage. Block Piercing could also be put on the system to determine how many blocks the arrows go through without touching mod files.

Hell Strider is a depth strider for lava, pretty self explanatory, only goes up to 2 though which is quite annoying next to depth strider.

I could probably think of more but I'll update later if you're interested in this idea!

Before submitting...

• [X] This issue is not a duplicate of an existing issue (open or closed).

[adibarra]

I think that the ability to modify enchantments added by other mods would be a great addition!

My only worry is that many mods create their own custom implementations for the enchantments they create and typically do a lot of hardcoding. In a nutshell, this would mean that whenever they update, we would need to manually add support for any enchantments they've added or changed (including code refactors).

That said, I'll look into the feasibility of a more generalized approach for trying to accomplish this.

Thanks for the suggestion!

[Ultimushadow]

I see, in that case perhaps a few of the mod authors could be convinced to add support for this mod, similar to how Mod Menu provides a way for mods to handle more general configs. If they coded things more closely to vanilla/in ways that made it easier for you to tweak with an all in one config, then I bet you could form a more cohesive way for enchantment mods in general to work together in one system rather than the more isolated form most mods are generally developed as. That being said, that uh, sounds like a lot of work, so I wouldn't be surprised if you decided to pass on that, but if you are interested and could use some help I could see what my free time allows me to do!