search

adicu / Courses

A course management application for Columbia.
courses.adicu.com
Other
16 stars 12 forks source link

Exempted Holidays #173

Closed G-ram closed 10 years ago

G-ram commented 10 years ago

Closes #154

G-ram commented 10 years ago

Yes.

natebrennand commented 10 years ago

this doesn't work for me with gcal when I tested it on gcal.

screenshot 2014-04-15 13 42 25

It's also buggy with the start dates. The first Wednesday class is skipped. I'm not sure what the best way of resolving this is.

screenshot 2014-04-15 13 39 49

Generated calendar for reference: https://gist.github.com/natebrennand/661c63852ff30f2315f6

natebrennand commented 10 years ago

if anyone else wants to test this, make sure to run bower update so the ics.js library is updated

natebrennand commented 10 years ago

I think the start date needs to be resolved in the library but checking the repeating days of the week vs. the start date.

G-ram commented 10 years ago

Should now start on the right day with holidays exempted.

natebrennand commented 10 years ago

works for me, can you squash the commits?