search

adicu / Courses

A course management application for Columbia.
courses.adicu.com
Other
16 stars 12 forks source link

Loading indicator for search #189

Closed brishin closed 9 years ago

brishin commented 10 years ago

Should be able to reuse our current loading indicator. Hook into it somehow.

schlosser commented 10 years ago

the blue bar?

brishin commented 10 years ago

Yes, the blue bar.

schlosser commented 10 years ago

I am thinking of doing some css restyling on the results window, and i think we should have a loading/ no results found indicator there. Thoughts?

brishin commented 10 years ago

I'm thinking loading could be the blue bar and then the results not found could be a part of an error/warning notification that is dismissible. I can walk you through some of the technical ideas I have on implementing something like that, if you're interested.

schlosser commented 10 years ago

Yeah I'm definitely interested. I think the best way to dismiss the results or lack thereof is to either press ESC or click outside the box. The former would probably require an external library, and the latter could be done by tying something like shouldShowResults to the search text box being active / selected.

What do you think?

On Tue, Jul 29, 2014 at 5:27 PM, Brian Donghee Shin < notifications@github.com> wrote:

I'm thinking loading could be the blue bar and then the results not found could be a part of an error/warning notification that is dismissible. I can walk you through some of the technical ideas I have on implementing something like that, if you're interested.

— Reply to this email directly or view it on GitHub https://github.com/adicu/Courses/issues/189#issuecomment-50541435.

brishin commented 10 years ago

Maybe we can add a red color to the loading indicator when nothing has been found?

Not sure how much is customizable. Check out my recent diff adding the loading indicator.

The package repo for meteor is here: atmospherejs.com

schlosser commented 10 years ago

I think a text message would be better On Jul 29, 2014 6:25 PM, "Brian Donghee Shin" notifications@github.com wrote:

Maybe we can add a red color to the loading indicator when nothing has been found?

Not sure how much is customizable. Check out my recent diff adding the loading indicator.

The package repo for meteor is here: atmospherejs.com

— Reply to this email directly or view it on GitHub https://github.com/adicu/Courses/issues/189#issuecomment-50548033.

brishin commented 10 years ago

Okay. In that case, you might want to take a look at local-only mongo collections.