search

adicu / Courses

A course management application for Columbia.
courses.adicu.com
Other
16 stars 12 forks source link

Fix weird redirect behavior #236

Closed brishin closed 9 years ago

brishin commented 9 years ago

It turns out that you're not supposed to use a reactive source aka Session.set/Session.get in routing code. I was using that before, which was causing the redirect function to fail silently if I used the Session line.

Should be able to go back from /schedule to / now as well as be redirected properly from / to /schedule

Closes #229

natebrennand commented 9 years ago

deferring to Dan on this since he knows Meteor better than I

schlosser commented 9 years ago

ping @brishin I'm :+1: after you explain a little about when that message is shown

brishin commented 9 years ago

So the only time people will see the home template is when they go back from /schedule to /. (Well also for a short second when the app is loading before the initial redirect happens).

Remember we had the problem that Courses was trapping people because it would instantaneously redirect?

schlosser commented 9 years ago

OK, so this will allow people to use the back button to go from /schedule to /, and then it won't immediately redirect them back to /schedule? That sounds good to me

On Sun, Nov 9, 2014, 10:47 AM Brian Donghee Shin notifications@github.com wrote:

So the only time people will see the home template is when they go back from /schedule to /. (Well also for a short second when the app is loading before the initial redirect happens).

Remember we had the problem that Courses was trapping people because it would instantaneously redirect?

— Reply to this email directly or view it on GitHub https://github.com/adicu/Courses/pull/236#issuecomment-62307571.