adie / mina-scp

Download/upload helpers for Mina deployer using SCP
MIT License
22 stars 7 forks source link

Fix exec #2

Closed jrhorn424 closed 10 years ago

jrhorn424 commented 10 years ago

This patch changes scp_transfer to use system or %x[] where appropriate, instead of exec. The reason is that exec takes over the thread and exits on success (more info). See issue #1.

jrhorn424 commented 10 years ago

Now, the result is only displayed if there's an error. I think this is better than leaving it out altogether. If accepted, this closes #1.

adie commented 10 years ago

Thanks for your patch!

jrhorn424 commented 10 years ago

You're welcome!