search

adiehl96 / BasicRFM

Matlab implementation of "Random function priors for exchangeable arrays with applications to graphs and relational data" by Lloyd et al (2012)
GNU General Public License v3.0
0 stars 0 forks source link

Incorrect Sampling Ratio #4

Closed adiehl96 closed 2 years ago

adiehl96 commented 2 years ago

https://github.com/adiehl96/BasicRFM/blob/260de885237f63ff64a1db7f69c7d1bd3be4fbb6/%40hcMCMC_SS_RFM/hcMCMC_SS_RFM.m#L34

The paper mentions that Balancing computational demands, we sampled T 50 times per iteration whilst all other variables were sampled once per iteration. However, the above code shows that the pseudopoints η are sampled 10 times per iteration. This should be changed to reflect the paper.

adiehl96 commented 2 years ago

This was changed in my reimplementation in python without a large drop in accuracy!