search

adiehl96 / BasicRFM

Matlab implementation of "Random function priors for exchangeable arrays with applications to graphs and relational data" by Lloyd et al (2012)
GNU General Public License v3.0
0 stars 0 forks source link

Removing V, VV, UCov and VCov #7

Closed adiehl96 closed 2 years ago

adiehl96 commented 2 years ago

Running highschool_predict, it seems to be the case that only the UU array actions contribute to the result. If this is true, then it might not be necessary to keep the V arrays around, whatever they were used for. Furthermore, during removal it might become clear what they were meant to do.

adiehl96 commented 2 years ago

https://github.com/adiehl96/BasicRFM/blob/f6c98f23abee6f8607268d9ba746bc65ce9b2aad/%40hcRFM/llh.m#L10 This file seemingly connects U and V arrays through the likelihood.

adiehl96 commented 2 years ago

https://github.com/adiehl96/BasicRFM/blob/f6c98f23abee6f8607268d9ba746bc65ce9b2aad/ExperimentAdmin/TestSpecification_Alt.csv~#L3 https://github.com/adiehl96/BasicRFM/blob/f6c98f23abee6f8607268d9ba746bc65ce9b2aad/ExperimentAdmin/sushi_100_10.csv~#L1 As seen above, V arrays are only specified for a sushi dataset (which doesn't seem to be included in the paper) and should therefore be able to be disregarded. (At least for the graph use case)

adiehl96 commented 2 years ago

https://github.com/adiehl96/BasicRFM/blob/f6c98f23abee6f8607268d9ba746bc65ce9b2aad/Interface/SetupObjects.m#L62 https://github.com/adiehl96/BasicRFM/blob/f6c98f23abee6f8607268d9ba746bc65ce9b2aad/Interface/SetupObjects.m#L131 The above lines suggest that not only V but also Ucov is an array that can be deleted, as it will never be set for the graph experiments that are presented in the paper. I will therefore also delete them here.

create-issue-branch[bot] commented 2 years ago

Branch issue-7-Removing_V_VV_UCov_and_VCov created!