adieyal / dynamicprompts

Templating language for generating prompts for text to image generators such as Stable Diffusion
MIT License
124 stars 20 forks source link

Allow attention generator to work without Spacy #85

Closed akx closed 1 year ago

akx commented 1 year ago

This makes the attention generator use a cheap and cheerful chunker that should probably work adequately for many prompts, if spaCy is not installed.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.04 :warning:

Comparison is base (c810884) 98.13% compared to head (4ca8d96) 98.10%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #85 +/- ## ========================================== - Coverage 98.13% 98.10% -0.04% ========================================== Files 70 70 Lines 2838 2845 +7 ========================================== + Hits 2785 2791 +6 - Misses 53 54 +1 ``` | [Impacted Files](https://app.codecov.io/gh/adieyal/dynamicprompts/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adi+Eyal) | Coverage Δ | | |---|---|---| | [tests/generators/test\_attentiongenerator.py](https://app.codecov.io/gh/adieyal/dynamicprompts/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adi+Eyal#diff-dGVzdHMvZ2VuZXJhdG9ycy90ZXN0X2F0dGVudGlvbmdlbmVyYXRvci5weQ==) | `100.00% <ø> (ø)` | | | [...rc/dynamicprompts/generators/attentiongenerator.py](https://app.codecov.io/gh/adieyal/dynamicprompts/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adi+Eyal#diff-c3JjL2R5bmFtaWNwcm9tcHRzL2dlbmVyYXRvcnMvYXR0ZW50aW9uZ2VuZXJhdG9yLnB5) | `89.36% <85.71%> (-0.39%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

akx commented 1 year ago

@adieyal Sorry for the barrage of force-pushes, this should now be stable to review :)