Closed adieyal closed 1 year ago
This is a pretty simple change. I would prefer to provide these settings in the constructor rather than setter methods, but until we can be confident that the extension will update the dynamicprompts library, I am hesitant to change method signatures. Thoughts?
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
bd83ee7
) 97.66% compared to head (e24c1ad
) 97.67%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Re - kwarg *
Suppose we push this release. Then modify the extension to allow for toggling deduplication and sorting. If someone updates their extension but their dynamicprompts doesn't update, then the code will break since the signature doesn't accept these new parameters.
I think we should wait to update the extension until https://github.com/adieyal/sd-dynamic-prompts/pull/449 is merged before updating the extension.
To maintain backwards compatibility, by default wildcards are sorted and deduplicated but this functionality can be disabled.