adieyal / dynamicprompts

Templating language for generating prompts for text to image generators such as Stable Diffusion
MIT License
124 stars 20 forks source link

Magic prompt: fix device typing, don't specify it by default #90

Closed akx closed 1 year ago

akx commented 1 year ago

I noticed the typing was "integer only", and defaulted to CPU, so I figured we could let Transformers decide instead.

Might help with https://github.com/adieyal/sd-dynamic-prompts/issues/302

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (8621043) 97.66% compared to head (bd83ee7) 97.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== - Coverage 97.66% 97.66% -0.01% ========================================== Files 70 70 Lines 2865 2864 -1 ========================================== - Hits 2798 2797 -1 Misses 67 67 ``` | [Impacted Files](https://app.codecov.io/gh/adieyal/dynamicprompts/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adi+Eyal) | Coverage Δ | | |---|---|---| | [tests/generators/test\_magicprompt.py](https://app.codecov.io/gh/adieyal/dynamicprompts/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adi+Eyal#diff-dGVzdHMvZ2VuZXJhdG9ycy90ZXN0X21hZ2ljcHJvbXB0LnB5) | `100.00% <ø> (ø)` | | | [src/dynamicprompts/generators/magicprompt.py](https://app.codecov.io/gh/adieyal/dynamicprompts/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adi+Eyal#diff-c3JjL2R5bmFtaWNwcm9tcHRzL2dlbmVyYXRvcnMvbWFnaWNwcm9tcHQucHk=) | `93.00% <100.00%> (+0.07%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.