search

adifyr / obsidian-chat-view

An elegant chat view for Obsidian pages.
MIT License
202 stars 11 forks source link

FR: add chat-view-color class also to the bubble div #2

Closed Cammagno closed 2 years ago

Cammagno commented 2 years ago

can the chat-vew-\<color> class be added also to the bubble div? In that way, one can use css to personalize the bubble differently for different speaking names :)

adifyr commented 2 years ago

I'll have to test it against multiple popular themes and see if the bubble still looks good. Will look into it.

Cammagno commented 2 years ago

I'll have to test it against multiple popular themes and see if the bubble still looks good.

Just to be sure that my FR is clear. The request was just to apply the chat-view-color class to the bubble div, not to add any default css effect to it (you can do it of course if you find it nice, but for my request the class itself is enough).

I try to explain the reason for this request. As it is now (class added to the chat-view-header only), I'm able to customize all the elements on the basis of who is speaking, using css selectors (for example: .chat-view-red ~ .chat-view-message), with only one exception: I can't customize chat-view-bubble div, because that div is a parent of the one with the chat-view-color.

adifyr commented 2 years ago

Hi @Cammagno. In light of your request, I have transferred the .chat-view-{color} classes to the containing div.chat-view-bubble. As per an initial test, everything should work the same way, but should now allow you to customize the "bubble div" as per your requirements.

I'm currently waiting for my plugin to get published on Obsidian. I'll create a new release then. Let me know if this solves your issue so I can close this.

Cammagno commented 2 years ago

Let me know if this solves your issue so I can close this.

It does, thank you!

Cammagno commented 2 years ago

Thanks for the new 1.1.0 release, that included this FR :)

It only leaves a small issue; in this way, the customization does not work for the headerless messages (see picture below).

image

Maybe is it possible to add the chat-view-color class also to the headerless bubbles following a header bubble?

Like this:

[Me=red, You=green] < Me | Text <-this bubble already has .chat-view-red < | More Text <- this bubble should have .chat-view-red < | More Text <- this bubble should have .chat-view-red > You | Answer <- this bubble already has .chat-view-green > | More Answer <- this bubble should have .chat-view-green

adifyr commented 2 years ago

Could you open a new issue and mark this as a bug?

Cammagno commented 2 years ago

Could you open a new issue and mark this as a bug?

I've created the new issue, but I don't know how to label it as a bug https://github.com/adifyr/obsidian-chat-view/issues/8

adifyr commented 2 years ago

Don't worry. I've taken care of that.