search

adigunsherif / Django-School-Management-System

School Management System based on Django framework.
MIT License
354 stars 197 forks source link

'added new login page' #19

Closed aman2457 closed 4 years ago

aman2457 commented 4 years ago

Hey @adigunsherif I've made a new login page with custom templates and some littile bit of bootstrap tweaks. can you please review it and merge it. My code will be li'l bit messy. ..

aman2457 commented 4 years ago

Greatly appreciated for this taking this initiative. Would come for a discussion if you wanna have.

Yeah sure. Is the pull request merged??

aman2457 commented 4 years ago

Hey @adigunsherif i have made some changes to my master. can you review it

aman2457 commented 4 years ago

hey @adigunsherif I've made the changes .. can you review it and merge it

adigunsherif commented 4 years ago

Sorry for the late reply. Will check and merge before the end of the day.

On Sat, Oct 3, 2020, 3:49 PM Aman Kumar notifications@github.com wrote:

hey @adigunsherif https://github.com/adigunsherif I've made the changes .. can you review it and merge it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adigunsherif/Django-School-Management-System/pull/19#issuecomment-703115363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHL6TAA3Y32A4AUAJVDLM3SI42YJANCNFSM4SAV66TA .

aman2457 commented 4 years ago

Great job @aman2457 . I have checked and confirmed this on my local setup. I have few comments before approving these changes.

  1. The background color on the login page is far from the overall color of the application itself. Can this be made as simple as the application is, like using a grey background or something close or no background.
  2. Since the application won't allow registration by external users, it makes sense not to have "create your account"
  3. Since the "Forgot Username / Password?" is not yet linked, please in your update, add the "password change" to the todo.txt file so we can keep track of this.
  4. I'm available to merge this night if you can work on these asap. Great job man

Hey @adigunsherif right now its 1:00am night. Can i work it early in the morning like after 8-10 hours. Will that be okay??

adigunsherif commented 4 years ago

No problem. At your convenience

On Sat, Oct 3, 2020, 7:48 PM Aman Kumar notifications@github.com wrote:

Great job @aman2457 https://github.com/aman2457 . I have checked and confirmed this on my local setup. I have few comments before approving these changes.

  1. The background color on the login page is far from the overall color of the application itself. Can this be made as simple as the application is, like using a grey background or something close or no background.
  2. Since the application won't allow registration by external users, it makes sense not to have "create your account"
  3. Since the "Forgot Username / Password?" is not yet linked, please in your update, add the "password change" to the todo.txt file so we can keep track of this.
  4. I'm available to merge this night if you can work on these asap. Great job man

Hey @adigunsherif https://github.com/adigunsherif right now its 1:00am night. Can i work it early in the morning like after 8-10 hours. Will that be okay??

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adigunsherif/Django-School-Management-System/pull/19#issuecomment-703148246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHL6TEOWAKHEEAZDD53J7TSI5WWNANCNFSM4SAV66TA .

aman2457 commented 4 years ago

@adigunsherif updated..

aman2457 commented 4 years ago

Screenshot from 2020-10-04 12-45-17

adigunsherif commented 4 years ago

Thank you for your effort. Will merge ASAP

On Sun, Oct 4, 2020, 8:16 AM Aman Kumar notifications@github.com wrote:

[image: Screenshot from 2020-10-04 12-45-17] https://user-images.githubusercontent.com/54279054/95009412-90624e00-063f-11eb-8496-5221c6eac488.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adigunsherif/Django-School-Management-System/pull/19#issuecomment-703214261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHL6TA6ZEFQJVW3WCK3S5LSJAONDANCNFSM4SAV66TA .

aman2457 commented 4 years ago

Thank you for your effort. Will merge ASAP … On Sun, Oct 4, 2020, 8:16 AM Aman Kumar @.***> wrote: [image: Screenshot from 2020-10-04 12-45-17] https://user-images.githubusercontent.com/54279054/95009412-90624e00-063f-11eb-8496-5221c6eac488.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHL6TA6ZEFQJVW3WCK3S5LSJAONDANCNFSM4SAV66TA .

yeah @adigunsherif it would be great. and after merging close this PR also