adikari / monorepo-diff-buildkite-plugin

Run separate pipelines for each folder in your monorepo
MIT License
202 stars 78 forks source link

Allow users to upload notifications #120

Closed JonathanLorimer closed 1 year ago

JonathanLorimer commented 1 year ago

This PR adds support for the per-step notify key that buildkite accepts.

https://buildkite.com/docs/pipelines/notifications

adikari commented 1 year ago

Can you provide details of what this PR is about and what problem it solves?

JonathanLorimer commented 1 year ago

Can you provide details of what this PR is about and what problem it solves?

Yes, Its only in draft right now because I was just testing it. I need to cleanup a lot of stuff (as you can see I modified the hooks executable for easier testing).

The gist is that I want to be able to provide a custom notify clause in the monorepo-plugin config so that I can customize the github commit statuses https://buildkite.com/docs/integrations/github#customizing-commit-statuses. Right now the yaml marshalling doesn't support this key.

codecov[bot] commented 1 year ago

Codecov Report

Merging #120 (640acd2) into master (c1ecdb9) will increase coverage by 3.13%. The diff coverage is 95.65%.

:exclamation: Current head 640acd2 differs from pull request most recent head 7eeaffa. Consider uploading reports for the commit 7eeaffa to get more accurate results

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   80.55%   83.68%   +3.13%     
==========================================
  Files           4        4              
  Lines         180      331     +151     
==========================================
+ Hits          145      277     +132     
- Misses         23       42      +19     
  Partials       12       12              
Impacted Files Coverage Δ
main.go 44.00% <0.00%> (-2.67%) :arrow_down:
util.go 93.54% <87.50%> (+0.21%) :arrow_up:
plugin.go 96.07% <100.00%> (+1.48%) :arrow_up:
pipeline.go 73.77% <0.00%> (+2.71%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.