adikari / monorepo-diff-buildkite-plugin

Run separate pipelines for each folder in your monorepo

MIT License

202 stars 78 forks source link

Build macOS binaries #76

Closed runlevel5 closed 3 years ago

runlevel5 commented 3 years ago

Fixes #64

runlevel5 commented 3 years ago

cc @adikari

codecov-commenter commented 3 years ago

Codecov Report

Merging #76 (d1ed5a4) into master (fe8e2e7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           4        4           
  Lines         155      155           
=======================================
  Hits          124      124           
  Misses         20       20           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe8e2e7...d1ed5a4. Read the comment docs.

adikari commented 3 years ago

@runlevel5 there seems to be issue with https://github.com/chronotc/monorepo-diff-buildkite-plugin/blob/master/Makefile#L34

When we are building multiple binaries each binary gets built then cleaned up on the next run. So we end up with only 1 binary in the end. While you are at it, could you fix this too?

runlevel5 commented 3 years ago

@adikari let me fix that issue for you

adikari commented 3 years ago

@runlevel5 pls fix the merge conflict and I will merge this too.

runlevel5 commented 3 years ago

@adikari please squash & merge this PR

runlevel5 commented 3 years ago

@adikari good to go

adikari commented 3 years ago

@runlevel5 ping me when fixed.

runlevel5 commented 3 years ago

@adikari let's go