search

adikari / monorepo-diff-buildkite-plugin

Run separate pipelines for each folder in your monorepo
MIT License
202 stars 78 forks source link

prevent incorrect interpolation of env on trigger steps #80

Closed chronotc closed 2 years ago

chronotc commented 2 years ago

Environment was incorrectly interpolated in 2 places. This removes the extra env on trigger steps.

Generated Pipeline:

steps:
- trigger: app
   build:
     message: 'chore(some-app): pass in correct env'
     branch: renovate/i-am-fake-renovate
     commit: 68d963ed7daee0c84f575eb4aa56c47d3dfd0ad4
     env:
       QUEUE_OVERRIDE: renovate
   env: (this shouldn't be here)
     QUEUE_OVERRIDE: renovate
codecov-commenter commented 2 years ago

Codecov Report

Merging #80 (db21e28) into master (602e650) will decrease coverage by 1.01%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   80.00%   78.98%   -1.02%     
==========================================
  Files           4        4              
  Lines         155      157       +2     
==========================================
  Hits          124      124              
- Misses         20       21       +1     
- Partials       11       12       +1
Impacted Files Coverage Δ
plugin.go 93.22% <77.77%> (-3.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 602e650...db21e28. Read the comment docs.