search

adikari / monorepo-diff-buildkite-plugin

Run separate pipelines for each folder in your monorepo
MIT License
202 stars 78 forks source link

fix: add logic to determine correct kernel + arch for binary download #84

Closed LColman-SEEK closed 2 years ago

LColman-SEEK commented 2 years ago

In hopes of fixing #83 . Added some basic logic to compare the $(arch) against a whitelist of known strings for the AMD and ARM architecture families. (the lists include some 32-bit varieties as arch itself allows selecting an architecture, so these 32-bit strings may be indicative of actual 64-bit ISC families).

Disclaimer: I see there is a ppc64le binary in the releases. I had never heard of that flavour of PowerPC until now, so yeah, ~didn't do anything to handle it~ [EDIT: I added a basic string check to whitelist it through 🤷 ]. But if someone (who has one) wants/knows what to check then feel free to amend the PR?

LColman-SEEK commented 2 years ago

Thanks @adikari! Would you, @chronotc, @xzyfer or any other maintainer with write access be kind enough to merge this?

xzyfer commented 2 years ago

Thanks for this. I'll aim to get this out this week

codecov-commenter commented 2 years ago

Codecov Report

Merging #84 (b5268eb) into master (40e837e) will increase coverage by 0.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   78.98%   79.26%   +0.28%     
==========================================
  Files           4        4              
  Lines         157      164       +7     
==========================================
+ Hits          124      130       +6     
- Misses         21       22       +1     
  Partials       12       12
Impacted Files Coverage Δ
main.go 50.00% <0.00%> (-3.85%) :arrow_down:
plugin.go 93.84% <0.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40e837e...b5268eb. Read the comment docs.

xzyfer commented 2 years ago

Released in v2.2.1