search

adiknoth / 4deckradio

Multi-deck media playback for radio stations
MIT License
5 stars 2 forks source link

Let GTK handle command line arguments. #6

Closed karllinden closed 11 years ago

karllinden commented 11 years ago

Hi,

I let GTK handle the command line arguments. It will give a little more nicely formatted help text (at least in my opinion). Also, the use of getopt can be dropped in favour of GTK and less code.

With this additional long option support is added (e.g --fullscreen).

I also updated the README.md to use a GTK'ish formatting, i.e, the formatting shown when --help flag is passed.

Please see what you think and merge thereafter!

adiknoth commented 11 years ago

Hi Karl,

thanks for your work, I'm definitely going to merge them. I could fix all the issues myself, but I thought you'd like to play a bit with git. ;)

Most importantly, please don't mix code and infrastructure changes. That is, the README.md should be a separate commit, same for the configure.ac change.

So assuming you haven't done any other commits, yet (if so, create a branch from 5645d48, something like git branch foo 5645d48 && git checkout foo), do a "git reset HEAD^" (yes, with ^) to remove the last commit without changing the files. Then, incorporate my suggested changes and finally create individual commits.

Maybe you'll find a tool like gitg helpful, though it's also dead easy on the command line: git commit mystreamer.c, then git commit configure.ac and git commit README.md.

gitg also allows for individual commits inside a single file, that is, you can stage one or more hunks.

TIA

karllinden commented 11 years ago

Great! Thank a lot for your help and advice! It works like a charm! :)

Well, here it is. Split up in three different commits.