[Android Bootcamp] Project 3: Twitter Client - ready for review

[adilansari]

My app is complete, please review. /cc @codepath @codepathreview

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
• Good use of string resources for text values
• Glad you thought about error handling for invalid or empty input cases
• Consider adding progress bars to your app whenever a network request goes out
• Consider including a check to see if internet is available to detect any network failures. Show an approrpiate message in case of failure.
• Good to see you were able to format the timestamp cleanly
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
• Good to see you added the tweet to the home timeline after you posted new on compose
• Nice touch with the character count being displayed while the user composes a tweet
• Glad to see you made the compose activity into a dialog instead
• Good to see you added ActiveAndroid annotations to the models

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[adilansari]

@codepathreview I had a hard time filling up the blank space around my action bar.

I tried all the help that guide had to offer, and decided to use toolbar since its new. Here is the code for my: Toolbar, SupportActionBar.

• Is it because I was setting theme twice in manifest?
• Also how can I set action bar throughout application and override only when an Activity needs.

[nesquena]

See this http://guides.codepath.com/android/Using-the-App-ToolBar#styling-the-toolbar

1. Set background color for toolbar as shown there
2. Remove contentinsetoffsets for toolbar as shown in that section on app icon

Read through that section carefully and experiment and let me know if you aren't able to get the intended effects.