adileo / squirreldisk

Beautiful, Cross-Platform and Super Fast Disk Usage Analysis Tool - Built With Rust πŸ¦€
https://squirreldisk.com
GNU Affero General Public License v3.0
741 stars 24 forks source link

ux improvements #18

Open PineappleRind opened 1 year ago

PineappleRind commented 1 year ago

β€” foundation for formatBytes function β€” separate path and progress into 2 lines in "Scanning" text β€” set window minWidth/minHeight

PineappleRind commented 1 year ago

@nkormakov i'm not sure if it's the easiest way to do this, but...if you'd like to be shown as a contributor i can invite you to my forkΒ β€” then you can add the formatBytes function to src/formatBytes.ts , just make sure to export it: export function formatBytes(/* ... */) { /* ... */ }

otherwise if you don't mind I can add it

(relevant issue: #17)

nkormakov commented 1 year ago

yes, let's make it this way, seems like original repo is quite dead

PineappleRind commented 1 year ago

OK, I've invited you - you can accept either by email or at https://github.com/PineappleRind/squirreldisk/invitations

then you'll have write access so you can add the function

Use this branch: https://github.com/PineappleRind/squirreldisk/tree/ux-improvements

nkormakov commented 1 year ago

Ok, I will take a look later into it, thanks! Any guides for compilation?

PineappleRind commented 1 year ago

you shouldn't need to compile it, I've added some code already in the necessary places that depends on a function in src/formatBytes.ts (that file is currently empty). all that's left is to put the function there and it will hopefully work, I can test it

this is so that you can be shown as a squirreldisk contributor :)

nkormakov commented 1 year ago

Done, just pasted as is from my comment in the main repo, fingers crossed!

PineappleRind commented 1 year ago

works! (just added an export)

Screenshot 2023-08-04 at 10 07 01 AM

This PR also separates scan target path and scan progress:

image