search

adinapoli / threads-supervisor

Simple, IO-based Haskell library for Erlang-inspired thread supervisors
MIT License
29 stars 4 forks source link

upgrade to LTS 5 #9

Closed srijs closed 8 years ago

srijs commented 8 years ago

Upgrades to Stackage LTS 5.

More specifically, migrates from retry 0.6.x to 0.7.x, which changed Int to RetryStatus. Since the OneForOne constructor is exposed, this will be a breaking change for this library.

adinapoli commented 8 years ago

Nice one!

I would like to keep this one pending until I do not release 1.0.4.1, and at that point I will roll out 1.1.0.0 to indicate the breaking change. The changelog would be updated to reflect that.

Incidentally, I think it might be beneficial some day to also bump the stack version travis is using as it's quite old:

https://github.com/adinapoli/threads-supervisor/blob/master/.travis.yml#L16

srijs commented 8 years ago

Sounds good! Would there be interest from your side to get the library into Stackage to make sure that it keeps being compatible with future releases?

adinapoli commented 8 years ago

@srijs I'm definitely not opposed in having it! I have already mandrill on Stackage. I didn't put this one as nobody asked me about :wink:

srijs commented 8 years ago

@adinapoli If it's not a nuisance to you, I'd certainly appreciate it.

As soon as this PR is merged, I'd probably start to work on a OneForAll strategy, if that's okay with you.

adinapoli commented 8 years ago

@srijs Totally fine by me! I will add a couple of extra tickets in the issue tracker to reflect what we want (release on Stackage and OneForAll strategy) and I will assign the latter to you.

Also, in case I forget, remind me to add you to the list of Contributors :wink: