search

adirh3 / Fluent-Search

Official repository for Fluent Search, use to report issues or ask for a new feature
https://fluentsearch.net
1.46k stars 34 forks source link

TortoiseGit unresponsive while FluentSearch is running #857

Closed JVimes closed 1 year ago

JVimes commented 1 year ago

Describe the bug

While FluentSearch is running, TortoiseGit takes around 3-10 sec to become responsive when doing certain operations (often opening or closing a window).

To Reproduce

  1. Install TortoiseGit
  2. In Windows Explorer, right click a repo folder > TortoiseGit > Git Show log
  3. Try any of:
    • Click the branch name in the upper left
    • Close log window
    • Other things, often involving opening/closing TortoiseGit windows

Expected behavior TortoiseGit is not unresponsive while FluentSearch is running.

Desktop (please complete the following information):

JVimes commented 1 year ago

The repro seems to happen more on some repos and not others. I wish I could post the repo I have that shows it the most (lags the most), but it's for work.

adirh3 commented 1 year ago

@JVimes please try disabling process search or in app content search in Settings -> Processes, or if you use these add this app to the ignore list.

JVimes commented 1 year ago

Thank you much. Adding TortoiseGitProc to the ignore list fixed it.

Do some apps just not play well with process search?

adirh3 commented 1 year ago

Thank you much. Adding TortoiseGitProc to the ignore list fixed it.

Do some apps just not play well with process search?

Glad it helped. Yes Fluent Search uses Windows accessibility feature to do in app content search and some apps do not have good accessibility support.

JVimes commented 1 year ago

Maybe a timeout would work as a failsafe? I'm assuming my unresponsive app caused an API call to not return for a long time since my window was totally frozen.

adirh3 commented 1 year ago

Maybe a timeout would work as a failsafe? I'm assuming my unresponsive app caused an API call to not return for a long time since my window was totally frozen.

I wish I could detect it, it's not even about timeout it's just Fluent Search call the accessibility api once, and since the software implementation does not handle it efficiently it may stuck in some cases. If I was able to detect it I would've ignored the software automatically.

JVimes commented 1 year ago

Ah, gotcha. I think TortoiseGitProc is a safe candidate for default exclusion in the app, should you decide. Thank you again!