search

adithya-s-sekhar / advanced-youtube-client-ayc

AYC is a highly responsive, no nonsense, easy to use, fast video downloader from the text based era.
https://advanced-youtube-client-ayc.sourceforge.io/
GNU General Public License v3.0
112 stars 4 forks source link

Selecting custom format doesn't download subtitles, metadata and doesn't follow custom naming format. #10

Closed FrostedVolcano closed 6 days ago

FrostedVolcano commented 1 month ago

Hi, found another issue, although I don't know if it's a bug or intentional.

Issue: Videos don't have subtitles, metadata, thumbnail and custom naming when format codes are entered manually.

Description: Under option 8 "Show all formats" when I select option 7 "Show even more formats (Enter format code manually)" and enter the video and audio format codes, the video downloads like plain yt-dlp, I mean subtitles, metadata, thumbnail are not downloaded and the videos doesn't have custom naming format.

Expected result: Videos should have subtitles, metadata, thumbnail and custom naming even if format codes are entered manually.

adithya-s-sekhar commented 1 month ago

Wierd, It's working here, can you share this url and the formats you selected?

FrostedVolcano commented 4 weeks ago

@adithya-s-sekhar sorry for late reply again. I don't remember which video I downloaded then, but this video also shows the same behaviour. The format codes are: 271+ba. The AYC version is 4.22 image The left is downloaded using yt-dlp with required commands or flags from the terminal, it embedds thumbnail, has custom naming, the right one is downloaded using AYC (271+ba) and as you can see, it doesn't have custom naming nor thumbnail. Thanks.

adithya-s-sekhar commented 4 weeks ago

Thanks for the heads up. The thumbnails are being embedded but windows couldn't display them due to the files having an mkv container. I changed it to mp4. You can try this build https://t.me/s/ayc_news or here https://we.tl/t-na1GcIiZlO. Subtitles should be there as well. If anything breaks do let me know.

Or you can replace these files from dev branch https://github.com/adithya-s-sekhar/advanced-youtube-client-ayc/blob/dev/resources/scripts/downloader/youtube.bat https://github.com/adithya-s-sekhar/advanced-youtube-client-ayc/blob/dev/resources/scripts/downloader/ytsearch.bat

As for the name, it's hardcoded into the above files for youtube to fix this bug #3 . You'd have to edit them to your needs.

adithya-s-sekhar commented 6 days ago

Fixed in v4.23.