adithya-s-sekhar / advanced-youtube-client-ayc

AYC is a highly responsive, no nonsense, easy to use, fast video downloader from the text based era.
https://advanced-youtube-client-ayc.sourceforge.io/
GNU General Public License v3.0
109 stars 4 forks source link

Doesn't download default (creator published) subtitles. #8

Open FrostedVolcano opened 3 days ago

FrostedVolcano commented 3 days ago

Description: When enabling subtitles (both .srt and embedded .vtt types), if the video on YouTube has both "auto-generated" and "Default" then only "Default" or both of these subtitles should be downloaded/added to the video file. But it only downloads/adds the "auto-generated" subs. "auto-generated" is the subtitles generated by YouTube and "Default" is the subtitle published by the creator. I also tried editing the "envetup.bat" , where I tried adding --write-subs in various ways, but it only downloads the auto generated one. I also tried removing --write-auto-subs and adding --write-subs but that doesn't download any subs. Issue: If the video has default subtitiles, then the default or both default and auto-generated should be downloaded, but it only downloads auto-generated subs. Expected results: Either only default or both default and auto generated subs should be downloaded.

adithya-s-sekhar commented 3 days ago

Hi can you share one of these video links? I've been wanting to test this behaviour for some time.

adithya-s-sekhar commented 1 day ago

@FrostedVolcano So I have tried this URL which has both a creator published eng subtitle and an auto generated eng subtitle. It downloaded the creator published subtitle when you set it to write the subtitle file externally. But it prefers the auto generated one when you try to embed it.

This is something currently being worked on by the yt-dlp team here: https://github.com/orgs/yt-dlp/projects/4/views/1?pane=issue&itemId=14786617

For now, we can fix this by writing to disk first, embed, then delete the creator published subtitle with --write-subs --write-auto-subs --embed-subs --compat-options no-keep-subs.

You can try this updated envsetup.bat file, see if it fixes your issue. envsetup.zip

Or this test build on telegram, haven't setup cd on github yet. ayc-v4.xx.zip