search

aditicsalunkhe / Simplii-Group74-2023

This repository has our copy of Simplii with enhancements to the original copy for Project-3, SE-2023
MIT License
0 stars 3 forks source link

Analytics Module - NoneType error #13

Closed aditicsalunkhe closed 11 months ago

aditicsalunkhe commented 11 months ago

Describe the bug When analytics module is selected, the application crashes when there are no tasks in the system.

To Reproduce Steps to reproduce the behavior: First, make sure that you do not have any tasks. i.e. View task shows nothing.

  1. Go to 'Dashboard'
  2. Click on 'Analytics'
  3. See the error - application crashes

Expected behavior A NoneType check before building graphs

purv2100 commented 11 months ago

Any specific reason why the application is crashing?

aditicsalunkhe commented 11 months ago

There isn't any check to verify if the data obtained from MongoDB database is not null. Will need to add NoneType check before building charts in Analytics module.

purv2100 commented 11 months ago

Okay, please go ahead and solve it. Thank you.

WangWangIsDog commented 11 months ago

There isn't any check to verify if the data obtained from MongoDB database is not null. Will need to add NoneType check before building charts in Analytics module.

Besides Null checker, maybe also need to check if data types are eligible for the analytics module?

purv2100 commented 11 months ago

There isn't any check to verify if the data obtained from MongoDB database is not null. Will need to add NoneType check before building charts in Analytics module.

Besides Null checker, maybe also need to check if data types are eligible for the analytics module?

Yes, that is true as well.

purv2100 commented 11 months ago

Also, we have a PR for this issue, so let's merge that PR and close this issue. Then try to solve other analytic issue.