Assignment Feedback

[codepathreview]

@aditilonhari after testing your code in emulator it seems that your infinite pagination is recycling the same tweets and not fetching older tweets in https://github.com/aditilonhari/MySimpleTweets/blob/master/app/src/main/java/com/codepath/apps/mysimpletweets/activities/TimelineActivity.java#L76

Please fix and resubmit

[aditilonhari]

@codepathreview : Fixed the issue of endless scrolling and resubmitted it.

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Nice to see you successfully used OAuth login. OAuth is widely used and it's important to understand OAuth v1 and v2 properly.
• Good to see you were able to format the timestamp cleanly.
• Nice to see you used the SwipeRefreshLayout for easy timeline refreshes.
• Good to see you added the new tweet directly to the home timeline after it was successfully posted to Twitter.
• Nice touch with the character count being displayed while the user composes a tweet.
• Consider using GSON to conveniently serialize and deserialize API responses into objects.
• Consider adding local persistence of tweets by using DBFlow in the Tweet and User. See the persistence guide and this other guide for more details.
• Nice to see you used DialogFragment. Fragment is an important component and its use is good practice.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[codepathreview]

:+1: Nice work. A few notes after checking out the code:

• Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, you have of code duplication in the Home, Mentions and Timeline fragments
• You have some duplication in TwitterClient also in the methods for getHomeTimeline, getMentionsTimeline, getUserTimeline. Also why do you need a count of 3 on mentions timeline?
• You should break down long methods into smaller methods. It makes the code easy to read and maintain.
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nice to see you used the ViewPager to properly setup the tabs
• Good to see you played with styling
• Consider adding local persistence of tweets by using DBFlow in the Tweet and User. See the persistence guide for more details.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.