Project Feedback!

[codepathreview]

:+1: Great work! A few notes after checking out the assignment:

• Clean UI, Good work on utilizing material design widgets like CardView, Snackbar, etc
• General comment: clean and modularised code, good job on that
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Nice to see you added the search box to the Toolbar!
• Good job using the ConnectivityManager to check for network availability
• Properly used spinners & check-boxes (with populated values) to allow users to select appropriate values.
• Properly sent and received relevant filters using a bundle to pass data between activities
• Good to see you used Parcelable over Serializable (benefits)
• Good to see you used a filters object Article to represent the filters to apply to the query
• Good job adding the ability to share a news article.
• Good job adding progress bars to your app whenever a network request goes out

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[codepathreview]

Hi @aditilonhari,

Per your recent query, please make sure that you follow the following code conventions:

• Follow consistency. Use ButterKnife everywhere (example - Toolbar in all activities)
• Follow AOSP and Java coding guidelines (example NoImageViewHolder rather than VH_Article
• Adapters and Fragments are can belong to two different packages. Refer this guide.

Let us know if you need additional information, let us know. Hope this helps.

Thanks, Codepath Review Team

[aditilonhari]

Sure. Thanks for the details.

I was confused about the second one though. For the coding conventions? Can you go into the specifics? Like did you mean to suggest to use same class along with exception when no image is found, instead of 2 separate classes?

On Mon, Oct 24, 2016 at 10:26 PM, CodePath Reviewers < notifications@github.com> wrote:

Hi @aditilonhari https://github.com/aditilonhari,

Per your recent query, please make sure that you follow the following code conventions:

• Follow consistency. Use ButterKnife everywhere (example - Toolbar in all activities https://github.com/aditilonhari/NYTimesSearch/blob/master/app/src/main/java/com/codepath/nytimessearch/activities/ArticleActivity.java )
• Follow AOSP https://source.android.com/source/code-style.html and Java http://www.oracle.com/technetwork/java/codeconventions-150003.pdf coding guidelines (example NoImageViewHolder rather than VH_Article https://github.com/aditilonhari/NYTimesSearch/blob/master/app/src/main/java/com/codepath/nytimessearch/models/VH_Article.java
• Adapters and Fragments are can belong to two different packages https://github.com/aditilonhari/NYTimesSearch/tree/master/app/src/main/java/com/codepath/nytimessearch/adapters. Refer this guide https://guides.codepath.com/android/Organizing-your-Source-Files.

Let us know if you need additional information, let us know. Hope this helps.

Thanks, Codepath Review Team

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aditilonhari/NYTimesSearch/issues/1#issuecomment-255939827, or mute the thread https://github.com/notifications/unsubscribe-auth/AR4tBHj0iEj2CkRX13xvphgXLhHKJsgsks5q3ZMAgaJpZM4Kecbx .

Thanks and Regards, Aditi Lonhari.