album art doesnt show up on any songs even though audio file has an embeded album art

[Felix-Kyun]

i've used ffmpeg to extract the image from audio file, my config

MPD_PORT : "6600"
MUSIC_DIRECTORY : "~/Media/music/"
SEEK_OFFSET : 5
CACHE_DIR : "~/.config/gomp/.cache/"
DEFAULT_IMAGE_PATH : "~/.config/gomp/default_art.png"

and the audio i was playing was located in ~/Media/music/nightcore/

[Felix-Kyun]

is there any other information that i can provide ? should i upload the audio file ?

[aditya-K2]

This is Happening because gomp only supports MP3 and FLAC files right now. But it would be helpful if you provide the audio file.

[Felix-Kyun]

https://we.tl/t-ZaCMvdbDUE its in m4a as all of my song are in that format

[Felix-Kyun]

looks ive hit another issue, normally it doesnt show any album art as gomp doesnt support m4a but one one of my files it crashes the whole program,

https://user-images.githubusercontent.com/99094581/197583547-0f22e839-ec47-496a-be30-32359300fbdf.mp4

as usual here's the audio file that caused this problem: https://we.tl/t-HCBJUofqDU

[aditya-K2]

Sorry, but I couldn't replicate the error with your config.

https://user-images.githubusercontent.com/51816057/197600632-cd7e7ea6-4f63-454d-94d0-a838e77e50f2.mp4

[Felix-Kyun]

can u think of any particular reason why this might not work on my device ? like some missing lib or deps

[aditya-K2]

I have recently pushed a commit for better error handling, can you update gomp and report if the issue still persists?

[Felix-Kyun]

Sorry, but I couldn't replicate the error with your config.

2022-10-25.00-07-26.mp4

even with newer version i got the exact same error while playing song, though on opening gomp it showed 'format not supported', though i managed to slove the crash issue, it was due to corrupted cache file, after clearing the whole cache dir, it works just fine now

[Felix-Kyun]

should i close this issue as gomp doesnt support m4a as of now ?

[aditya-K2]

You can leave it open.

[aditya-K2]

@Felix-Kyun I have opened a PR for adding support for more audio formats. Can you please test it and report it?

1. Please remove all the contents from your cache folder before testing.

   $ git clone https://github.com/aditya-K2/gomp && git checkout tags && go build #to build
   $ ./gomp #to run 

[Felix-Kyun]

https://user-images.githubusercontent.com/99094581/198211534-321875bf-5586-41f0-aa4d-8760b62e0857.mp4

still the same problem

[aditya-K2]

simplescreenrecorder-2022-10-27_12.18.50.mp4 still the same problem

Thanks for reporting the bugs. There was an edge case where the path was returned empty I have solved it. Can you please check and report if this solves the problem? Thanks once again. 🤝

git pull origin tags && go build

[Felix-Kyun]

simplescreenrecorder-2022-10-27_12.18.50.mp4 still the same problem

Thanks for reporting the bugs. There was an edge case where the path was returned empty I have solved it. Can you please check and report if this solves the problem? Thanks once again. handshake

git pull origin tags && go build

https://user-images.githubusercontent.com/99094581/198339048-bc8b35bb-c5bf-4a94-8f31-9c92bf66cdc7.mp4

it still doesnt show the image, but it succesfully extracts the images from audio files,

but as u can see the permission on the images r a mess

[Felix-Kyun]

ok so after fixing the file permission manually it succesfully renders the image in gomp, so ig u just need to fix the file perm after extracting it

[aditya-K2]

ok so after fixing the file permission manually it succesfully renders the image in gomp, so ig u just need to fix the file perm after extracting it

I see. I will Fix that.

[aditya-K2]

I have pushed the changes. Can you please check if it solves the problem? and report.

[Felix-Kyun]

ok it works :D

btw just off topic, why do some songs appear like this like instead of showing 'name - artist - smth' on some songs it shows just 'path to file' as u can see at the lower half of the screenshot ?

[aditya-K2]

I have merged the PR. I will close this issue. You can update gomp.

yay -S gomp-git