aditya-grover / climate-learn

Source code for ClimateLearn
MIT License
310 stars 49 forks source link

Refactor stacked climate dataset #103

Closed prakhar6sharma closed 1 year ago

prakhar6sharma commented 1 year ago

Issues fixed by this PR:

Solution implemented:

prakhar6sharma commented 1 year ago

To Do:

prakhar6sharma commented 1 year ago

I'm 50-50 on this, so you could convince me either way, but why does name need to be a parameter for ClimateDatasetArgs. For example, if I use ERA5Args, it just makes sense that the name is "era5". A compromise solution could be that the default name is "era5", but we still allow the user to specify a different name.

Why name need to be a parameter for ClimateDatasetArgs: Suppose we are doing downscaling. For the typical setup that we support, both high_res and low_res data are from ERA5. Thus keeping the name as "era5" for both of them would lead to ambiguity. Right now, there is a default name for every different ClimateDatasetArgs class, for ERA5Args that happen to be "era5".