search

aditya-grover / climate-learn

Source code for ClimateLearn
MIT License
310 stars 49 forks source link

inconsistency between tutorial notebook and resnet model #52

Closed bulaienTang closed 1 year ago

bulaienTang commented 1 year ago

Describe the bug "upsampling" removed in resnet kwargs but still being passed in NeurIPS2022_CCAI_Tutorial.ipynb

To Reproduce run the downscaling section of NeurIPS2022_CCAI_Tutorial.ipynb

Expected behavior the model should not accept "upsampling" as a parameter

Screenshots

Screenshot 2023-02-06 at 11 09 20 PM
tung-nd commented 1 year ago

Please remove the upsampling parameter in the notebook, as it is no longer required. Detailed explanation here: https://github.com/aditya-grover/climate-learn/pull/44#issuecomment-1416638937

bulaienTang commented 1 year ago

Done.