Closed Substancia closed 2 years ago
If you're creating new files, please put them in respective new folders INSIDE "components" folder from now on. And to make changes to existing files, please let me know when no one is doing critical work, to avoid merge conflicts and breaking changes.
cc:// @chiggshiggs @aditya-singh9 @YasirObaibullah99 @Nogueira-lucas @kunaaal13
Hello , @Substancia as you have mentioned about restructuring of the current code base which will improve the readability , I have worked upon it and made separate folders for each of the features and also changes the respective file locations (path) . . . You can assign this issue to me and i will make a PR :)
We should update the contributing.md
Should i make a PR of :-
I had asked earlier about making this restructuring myself, had a chat with @aditya-singh9 , decided to wait till everyone's critical work are done to avoid merge conflicts for everyone.
I am very keen about this and would like to get on this (especially with my other issue closed I have bandwidth now to orchestrate with everyone individually), but I'll be good with whoever @aditya-singh9 assigns this to.
you can take this i am working on the UI part :)
I think i will assign it to @Substancia because he started this thread and thought of restructuring.
Example of what I'd like to implement: https://github.com/Substancia/OneshotAI-MERN-client-webapp/
@aditya-singh9 looks like coast is clear for this issue solving. Out of 4 currently active issues, 2 seem to be unaffected (as per their assignees), and 2 are mine with PRs up and ready to be merged. Once mine are merged, I can immediately get into this before someone starts another issue with critical work.
@Substancia Have to done #41 issue then please merge it
@YasirObaibullah99 sorry, did you mean that I wait till you finish your work? If so, when are you expecting to raise you PR?
I have already raised the PR
Cool, I'll wait till your PR is merged. Thanks.
@aditya-singh9 PR has been raised. Added couple comments in PR to describe the changes made.
The code files need to be restructured for better readability (especially in the future when more files are created). Basically different components (js files and their supporting files like css) need to go into a folder, so that the containers folder has only folders in it. This helps compartmentalise the code better.