aditya-singh9 / kekfinder

Emoji finding tool
https://kekfinder.vercel.app
MIT License
27 stars 17 forks source link

Code restructuring #41

Closed Substancia closed 2 years ago

Substancia commented 2 years ago

The code files need to be restructured for better readability (especially in the future when more files are created). Basically different components (js files and their supporting files like css) need to go into a folder, so that the containers folder has only folders in it. This helps compartmentalise the code better.

Substancia commented 2 years ago

If you're creating new files, please put them in respective new folders INSIDE "components" folder from now on. And to make changes to existing files, please let me know when no one is doing critical work, to avoid merge conflicts and breaking changes.

cc:// @chiggshiggs @aditya-singh9 @YasirObaibullah99 @Nogueira-lucas @kunaaal13

Rudresh-pandey commented 2 years ago

Hello , @Substancia as you have mentioned about restructuring of the current code base which will improve the readability , I have worked upon it and made separate folders for each of the features and also changes the respective file locations (path) . . . You can assign this issue to me and i will make a PR :)

Rudresh-pandey commented 2 years ago

We should update the contributing.md

Rudresh-pandey commented 2 years ago

Should i make a PR of :-

  1. Creating different folders which contains js and their respective css files
  2. Updating the contribution.md (adding necessary info about creating separate folders for each features made by the contributers)
Substancia commented 2 years ago

I had asked earlier about making this restructuring myself, had a chat with @aditya-singh9 , decided to wait till everyone's critical work are done to avoid merge conflicts for everyone.

I am very keen about this and would like to get on this (especially with my other issue closed I have bandwidth now to orchestrate with everyone individually), but I'll be good with whoever @aditya-singh9 assigns this to.

Rudresh-pandey commented 2 years ago

you can take this i am working on the UI part :)

aditya-singh9 commented 2 years ago

I think i will assign it to @Substancia because he started this thread and thought of restructuring.

Substancia commented 2 years ago

Example of what I'd like to implement: https://github.com/Substancia/OneshotAI-MERN-client-webapp/

Substancia commented 2 years ago

@aditya-singh9 looks like coast is clear for this issue solving. Out of 4 currently active issues, 2 seem to be unaffected (as per their assignees), and 2 are mine with PRs up and ready to be merged. Once mine are merged, I can immediately get into this before someone starts another issue with critical work.

yasirobai99 commented 2 years ago

@Substancia Have to done #41 issue then please merge it

Substancia commented 2 years ago

@YasirObaibullah99 sorry, did you mean that I wait till you finish your work? If so, when are you expecting to raise you PR?

yasirobai99 commented 2 years ago

I have already raised the PR

Substancia commented 2 years ago

Cool, I'll wait till your PR is merged. Thanks.

Substancia commented 2 years ago

@aditya-singh9 PR has been raised. Added couple comments in PR to describe the changes made.