search

aditya-singh9 / kekfinder

Emoji finding tool
https://kekfinder.vercel.app
MIT License
27 stars 17 forks source link

newUI #71

Closed Rudresh-pandey closed 2 years ago

Rudresh-pandey commented 2 years ago

newUI for desktop view and mobile view

see issue #46 for more

:)

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kekfinder ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 6:44PM (UTC)
aditya-singh9 commented 2 years ago

Can you please address this issue

I used desktop view in mobile phone and this showed up

Screenshot_20221005-001949_Chrome.jpg

Rudresh-pandey commented 2 years ago

Because i made this responsive only for desktop and mobile. I think i have to make more media queries .

Rudresh-pandey commented 2 years ago

How can we code for desktop view in mobile . @aditya-singh9 , @Substancia

Rudresh-pandey commented 2 years ago

https://user-images.githubusercontent.com/96531798/193963955-98aa2594-ffd5-47f5-a18b-24dcc4f28202.mp4

Rudresh-pandey commented 2 years ago

need to push again the changes

aditya-singh9 commented 2 years ago

You do not have to close the pr if you want to add some code to it

You can just commit the new changes to the fork and it will reflect here and then i can merge the pr.

Example: https://github.com/aditya-singh9/v2/pull/8